Skip to content

fix(market-installer): ensure bundled Node and pnpm runtimes are used for plugin installation - #61

Merged
wisdomqin merged 3 commits into
mainfrom
codex/market-installer-bundled-runtime
Aug 17, 2026
Merged

fix(market-installer): ensure bundled Node and pnpm runtimes are used for plugin installation#61
wisdomqin merged 3 commits into
mainfrom
codex/market-installer-bundled-runtime

Conversation

@yaojin3616

Copy link
Copy Markdown
Contributor

Summary

  • Bundled pnpm dependency: Added pnpm: 10.34.5 directly to root package.json dependencies to ensure it is always included in the packaged Electron distribution.
  • Node & pnpm Shims: Enhanced ensurePnpmShim in packages/dsh-desktop-market-installer to generate shims for both pnpm and node (supporting .cmd on Windows and executable shell scripts on POSIX), pointing directly to the app's bundled Node runtime (process.execPath).
  • Path Resolution: Prepended both the .desktop-bin directory and the bundled Node runtime directory to PATH (handling Windows Path/PATH case differences), guaranteeing that any plugin install or subprocess runs with the bundled runtimes without requiring a system Node.js install.
  • Tests: Added test assertions to test/market-installer.test.js to verify that both node and pnpm shims are properly generated.

@wisdomqin
wisdomqin merged commit b27c5b8 into main Aug 17, 2026
8 checks passed
@wisdomqin
wisdomqin deleted the codex/market-installer-bundled-runtime branch August 17, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants